fix: pad entry string in l1 to l2 tests#796
Merged
Merged
Conversation
ludamad
approved these changes
Jun 9, 2023
ludamad
left a comment
ludamad
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, technically hard to tell if fixed but we can be optimistic on this one
Member
Author
|
yeah agree its hard to tell, however fr.toString() does go to the smallest size, i think it was just a hash getting lucky and ending up being under 32 bytes. But yet again its all speculation |
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #795
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist: